fix(storage): fix sub level id for time travel #18886
Merged
+9
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Since sublevel ids no longer ensure a monotonically increasing order, and the time travel doesn't keep version delta of compaction, for time travel it's possible the newly inserted sub level id is smaller than the smallest one in the current version. For example:
The problem is time travel doesn't include the delta from step 2. So in step 3 it will be inserting sublevel 2 into sublevels [1, 2, 3], which will be rejected.
This PR fixes it by setting sub level id later in apply_version_delta, instead of persisting it in delta.
https://risingwave-labs.slack.com/archives/C05MQT5DFTP/p1728718540051539
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.