Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): fix sub level id for time travel #18886

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Oct 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Since sublevel ids no longer ensure a monotonically increasing order, and the time travel doesn't keep version delta of compaction, for time travel it's possible the newly inserted sub level id is smaller than the smallest one in the current version. For example:

  1. The version has 3 sublevels [1, 2, 3].
  2. The version is compacted to 0 sublevels [].
  3. A new sublevel is inserted, using committed_epoch as sub_level id. Say committed_epoch is 2, resulting sublevels [2].

The problem is time travel doesn't include the delta from step 2. So in step 3 it will be inserting sublevel 2 into sublevels [1, 2, 3], which will be rejected.

This PR fixes it by setting sub level id later in apply_version_delta, instead of persisting it in delta.

https://risingwave-labs.slack.com/archives/C05MQT5DFTP/p1728718540051539

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LTGM

src/meta/src/hummock/manager/transaction.rs Outdated Show resolved Hide resolved
@zwang28 zwang28 enabled auto-merge October 12, 2024 08:48
@zwang28 zwang28 added this pull request to the merge queue Oct 12, 2024
Merged via the queue into main with commit 798896f Oct 12, 2024
34 of 35 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_time_travel_replay branch October 12, 2024 09:21
zwang28 added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants