-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(over window): add compute count metric for general over window executor #18847
Merged
+192
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
stdrc
changed the title
add compute count metric
feat(over window): add compute count metric for general over window executor
Oct 10, 2024
fuyufjh
approved these changes
Oct 10, 2024
stdrc
force-pushed
the
rc/move-over-partition-methods
branch
from
October 10, 2024 13:35
fa1c2bf
to
736972c
Compare
stdrc
force-pushed
the
rc/add-metrics-to-general-over-window
branch
from
October 10, 2024 13:35
fb31da2
to
e58a7ef
Compare
Li0k
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the effort
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
stdrc
force-pushed
the
rc/add-metrics-to-general-over-window
branch
from
October 10, 2024 14:20
e58a7ef
to
94f4936
Compare
Li0k
pushed a commit
that referenced
this pull request
Oct 11, 2024
…xecutor (#18847) Signed-off-by: Richard Chien <[email protected]>
stdrc
added a commit
that referenced
this pull request
Nov 8, 2024
…xecutor (#18847) Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add a metric displaying
compute count
andsame result count
for general over window executor, which can serve as a guide for further optimization to result re-computation.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.