Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(batch): fix distributed batch query not properly throwing errors to PG client #18812

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #18790.

#18786, which is previously blocked by this issue will demonstrate that the bug is fixed correctly.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Oct 8, 2024

@stdrc stdrc changed the title throw root stage error through query_result_fetcher channel fix(batch): fix distributed batch query not properly throwing errors to PG client Oct 8, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Oct 8, 2024
@stdrc stdrc marked this pull request as ready for review October 8, 2024 10:16
@stdrc stdrc requested review from chenzl25 and KeXiangWang October 8, 2024 10:17
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@stdrc stdrc enabled auto-merge October 8, 2024 19:30
@stdrc stdrc force-pushed the rc/fix-distributed-batch-query-error-reporting branch from 213e88a to 851adc9 Compare October 8, 2024 19:33
Copy link
Contributor

@KeXiangWang KeXiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@stdrc stdrc added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit c96c913 Oct 8, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/fix-distributed-batch-query-error-reporting branch October 8, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: bad batch query succeeds when QUERY_MODE is distributed
3 participants