Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): avoid removing control stream node when failed to send request #18767

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Sep 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix recovery test panic.

In ControlStreamManager, we always maintain that workers in field nodes are consistent to workers in response_streams. However, in method remove_partial_graph, we use retain when trying to send request, and will remove the node when failing to send the request, but we didn't remove the corresponding stream in response_streams, which causes inconsistency and causes subsequent panics. In this PR, we fix this inconsistency by storing the response_stream together with the request sender in the ControlStreamNode. Previously we have to introduce a FutureUnordered to concurrently poll the several response streams. In this PR, we change to implement the concurrent poll logic on our own by poll_fn, so that we don't need to separate the request sender and response stream.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 changed the title fix: reproduce recovery test error fix(meta): avoid removing control stream node when failed to send request Sep 30, 2024
@wenym1 wenym1 enabled auto-merge October 8, 2024 03:55
@wenym1 wenym1 added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 24a6851 Oct 8, 2024
32 of 34 checks passed
@wenym1 wenym1 deleted the yiming/fix-control-stream-recovery-test branch October 8, 2024 04:53
github-merge-queue bot pushed a commit that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants