refactor: add metrics for time travel and recent versions #18690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenym1
reviewed
Sep 27, 2024
| @@ -740,6 +751,14 @@ impl MetaMetrics { | |||
| ) | |||
| .unwrap(); | |||
|
|
|||
| let opts = histogram_opts!( | |||
There was a problem hiding this comment.
Have we monitored the rate (frequency) of fetching time travel version?
There was a problem hiding this comment.
Yes, it can be derived from time_travel_version_replay_latency.
Added to grafana.
| @@ -342,7 +346,7 @@ impl HummockManager { | |||
| let sst_count = sst_ids.len(); | |||
| let mut sst_id_to_info = HashMap::with_capacity(sst_count); | |||
| let sst_info_fetch_batch_size = std::env::var("RW_TIME_TRAVEL_SST_INFO_FETCH_BATCH_SIZE") | |||
| .unwrap_or_else(|_| "100".into()) | |||
| .unwrap_or_else(|_| "10000".into()) | |||
There was a problem hiding this comment.
Shall we move this env var to the meta opt instead of implicitly reading an env var here?
And any reason to change from 100 to 10000?
There was a problem hiding this comment.
Shall we move this env var to the meta opt instead of implicitly reading an env var here?
OK
And any reason to change from 100 to 10000?
To speed up time travel version replay, i.e. less SELECT queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add metrics to monitor the efficiency of compute node's recent versions and meta node's time travel.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.