Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): build 2.0.0 from source in backwards compat test #18649

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kwannoel
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Same as https://github.com/risingwavelabs/risingwave/pull/18562/files#diff-2cd274f1db89f49e0ff90c98f5b8cbbd66241f386285b2193b5121d5c4aacbeaR105.

Currently 2.0.0 is dynamicaly linked, and openssl 1.1 is not present in the environment. So we can just build it from source.

2.0.1 onwards it should be statically linked thanks to #18569.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested review from stdrc and lmatz September 24, 2024 02:03
@github-actions github-actions bot added the type/fix Bug fix label Sep 24, 2024
@kwannoel kwannoel force-pushed the kwannoel/fix-backwards-compat-2.0 branch from ddd281a to 4f2a04d Compare September 24, 2024 03:30
@github-actions github-actions bot added the type/fix Bug fix label Sep 24, 2024
@graphite-app graphite-app bot requested a review from a team September 24, 2024 03:58
@kwannoel kwannoel added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 6eaecbb Sep 24, 2024
31 of 32 checks passed
@kwannoel kwannoel deleted the kwannoel/fix-backwards-compat-2.0 branch September 24, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants