Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(state table): replace new_ series with gen_ series #18566

Merged
merged 9 commits into from
Sep 18, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Sep 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously StateTable::new_ series of constructors are used in test code to create a temporary state table instance. However at the same time we have gen_ series of functions basically serving the same functionality in stream::common::table::test_utils.

To make our test code use the same way to construct state tables as non-test code, this PR changes all new_ calls to from_table_catalog + gen_ calls.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Sep 17, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title rename gen_prost_table to gen_pbtable refactor(state table): replace new_ series of constructors with gen_ series of pb table catalog generator Sep 17, 2024
@stdrc stdrc changed the title refactor(state table): replace new_ series of constructors with gen_ series of pb table catalog generator refactor(state table): replace new_ series with gen_ series test utils Sep 17, 2024
@stdrc stdrc changed the title refactor(state table): replace new_ series with gen_ series test utils refactor(state table): replace new_ series with gen_ series Sep 17, 2024
@stdrc stdrc marked this pull request as ready for review September 17, 2024 17:45
Signed-off-by: Richard Chien <[email protected]>
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for cleaning this up!

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stdrc stdrc added this pull request to the merge queue Sep 18, 2024
Merged via the queue into main with commit 24336eb Sep 18, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/simplify-state-table-api branch September 18, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants