refactor(batch): schedule with streaming mapping if serving is temporarily unavailable #18505
+21
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
…arily unavailable Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/serving-fallback-to-streaming
branch
from
d95bb34 to
2b00327
Compare
yezizp2012
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
If the serving mapping of a fragment is temporarily unavailable due to asynchronous notification, we fallback to use the streaming mapping to schedule. Note that the streaming mapping must be available, even if the table is just created, as we guarantee its notification goes prior to the catalog.
The reason for this change is to enable support for per-fragment variable vnode count. If we lack information about a fragment's mapping, it can be challenging to create a dummy vnode mapping with an unknown length.
This is an alternative of #10815.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.