fix: empty string as license key stuck docker compose #18421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <[email protected]>
|
& does this pr need to be cherry-picked to release-2.0? |
BugenZhao
reviewed
Sep 5, 2024
BugenZhao
reviewed
Sep 5, 2024
| @@ -60,7 +60,6 @@ services: | |||
| ENABLE_TELEMETRY: ${ENABLE_TELEMETRY:-true} | |||
| RW_TELEMETRY_TYPE: ${RW_TELEMETRY_TYPE:-"docker-compose"} | |||
There was a problem hiding this comment.
Can you also check whether this is expected?
BugenZhao
approved these changes
Sep 10, 2024
huangjw806
approved these changes
Sep 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: tabVersion <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
Signed-off-by: tabVersion <[email protected]> Co-authored-by: Bohan Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title, we do a license check when bootstrap, we actually get an empty string and try to interpret it as a license key, leading to a check error on compute node.
We expect it to be NULL and start the server as a free-tier.
The case does not cause any trouble because the check is introduced in v2.0, which has not been rolled out.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.