Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(stream): set noop_update_hint when jsonb access exists #18065

Merged
merged 5 commits into from
Aug 20, 2024
Merged

perf(stream): set noop_update_hint when jsonb access exists #18065

merged 5 commits into from
Aug 20, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As noted by a customer, we cannot eliminate the no-op Updates if the query is simple extracting fields from a jsonb payload. It's very likely that the payload changed but the needed fields are not changed. This PR set the no-op updates hint for such cases.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc
fix typo
ff6d108 
Signed-off-by: Richard Chien <[email protected]>
BugenZhao
BugenZhao reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of hack to me 🥵

@stdrc
Copy link
Member Author

stdrc commented Aug 16, 2024

Kind of hack to me 🥵

Can we make it heuristic? Like, do the compaction at first, if there's no such no-op updates for a while, we can turn off automatically. We can still do compaction from time to time so that we can turn on again.

st1page
st1page approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we do this for all projects where the output columns do not include all the input columns

chenzl25
chenzl25 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. It seems useful when mongodb source and schemaless kafka source are used,

@stdrc stdrc enabled auto-merge August 20, 2024 03:57
@stdrc
fix planner test
cac3162 
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc added this pull request to the merge queue Aug 20, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
@stdrc
perf(stream): set noop_update_hint when jsonb access exists (#18065)
40d390e 
Signed-off-by: Richard Chien <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@stdrc stdrc added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@stdrc stdrc added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@stdrc stdrc enabled auto-merge August 20, 2024 15:32
@stdrc stdrc added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit ed73a52 Aug 20, 2024
29 of 30 checks passed
@stdrc stdrc deleted the rc/noop-updates-elimination-for-jsonb-extraction branch August 20, 2024 15:59
zwang28 pushed a commit that referenced this pull request Aug 28, 2024
@stdrc @zwang28
perf(stream): set noop_update_hint when jsonb access exists (#18065)
9081ebb 
Signed-off-by: Richard Chien <[email protected]>
(cherry picked from commit ed73a52)
xxhZs pushed a commit that referenced this pull request Aug 30, 2024
@stdrc @xxhZs
perf(stream): set noop_update_hint when jsonb access exists (#18065)
070ca06 
Signed-off-by: Richard Chien <[email protected]>
(cherry picked from commit ed73a52)
zwang28 pushed a commit that referenced this pull request Sep 5, 2024
@stdrc @zwang28
perf(stream): set noop_update_hint when jsonb access exists (#18065)
970d0dd 
Signed-off-by: Richard Chien <[email protected]>
(cherry picked from commit ed73a52)
@zwang28 zwang28 mentioned this pull request Sep 5, 2024
Merged
9 tasks
github-merge-queue bot pushed a commit that referenced this pull request Sep 5, 2024
@zwang28 @stdrc
perf(stream): set noop_update_hint when jsonb access exists (#18065) (
01b7398 
#18412)

Co-authored-by: Richard Chien <[email protected]>
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Closed
stdrc added a commit that referenced this pull request Oct 17, 2024
@stdrc
perf(stream): set noop_update_hint when jsonb access exists (#18065)
6e97fa1 
Signed-off-by: Richard Chien <[email protected]>
(cherry picked from commit ed73a52)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao left review comments

@st1page st1page st1page approved these changes

@chenzl25 chenzl25 chenzl25 approved these changes

Assignees
No one assigned
Labels
need-cherry-pick-release-2.0 type/perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stdrc @chenzl25 @BugenZhao @st1page