Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable hakari #16142

Merged
merged 4 commits into from
Apr 4, 2024
Merged

build: disable hakari #16142

merged 4 commits into from
Apr 4, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Apr 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

hakari brings trouble

  • makes dependabot not work well
  • sometimes makes people confused what dependencies/features are build

We also don't enjoy he benefits of hakari due to some unknown reasons: If we cargo build -p risingwave_cmd_all, and then cargo test -p risingwave_frontend, it rebuilds from log, so many crates are being rebuilt.

So I prefer to disable it for now

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from a team as a code owner April 4, 2024 05:53
@xxchan
Copy link
Member Author

xxchan commented Apr 4, 2024

image image

It seems previously, feature failpoints is enabled

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@xxchan xxchan enabled auto-merge April 4, 2024 10:02
@xxchan xxchan added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 9a0da57 Apr 4, 2024
26 of 27 checks passed
@xxchan xxchan deleted the xxchan/hakari branch April 4, 2024 16:55
yezizp2012 pushed a commit that referenced this pull request Apr 7, 2024
@xxchan xxchan mentioned this pull request May 2, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants