refactor: memory management #13636
Merged
refactor: memory management #13636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13636 +/- ##
==========================================
+ Coverage 68.04% 68.08% +0.03%
==========================================
Files 1517 1517
Lines 261828 261735 -93
==========================================
+ Hits 178163 178202 +39
+ Misses 83665 83533 -132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Little-Wallace
added a commit
that referenced
this pull request
Nov 27, 2023
commit a3ea7c0 Author: Eric Fu <[email protected]> Date: Sat Nov 25 11:00:48 2023 +0800 refactor: memory management (#13636) commit 2348a2b Author: Bugen Zhao <[email protected]> Date: Fri Nov 24 18:26:48 2023 +0800 fix(streaming): use correct label for `stream_fragment_exchange_bytes` metrics (#13644) Signed-off-by: Bugen Zhao <[email protected]> commit 3ccb249 Author: Runji Wang <[email protected]> Date: Fri Nov 24 17:39:12 2023 +0800 fix: estimate jsonb's value encoding size (#13643) Signed-off-by: Runji Wang <[email protected]> commit 7b21e04 Author: Dylan <[email protected]> Date: Fri Nov 24 16:54:38 2023 +0800 feat(optimizer): improve inline session timezone in exprs (#13640) Signed-off-by: Little-Wallace <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This part of code became too shitty due to several changes in the history, so I decided to refactor this part first. This PR is a pure refactor without any changes to the logic.
MemoryManager(mostly fromGlobalMemoryManager) offers interface to other components and calls theLruWatermarkControllerin certain intervalLruWatermarkController(mostly fromJemallocAndJvmMemoryControl) executes the real controlling work, including collecting statistics from Jemalloc & JVM and generate a new LRU watermark epoch.config.rsLater, I will do #13610 (comment) on top of this refactoring.(Thinking...)Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.