-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(binder): refine resolve source schema #10195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
BugenZhao
changed the title
refactor(binder): refline resolve source schema
refactor(binder): refine resolve source schema
Jun 15, 2023
github-actions
bot
added
the
user-facing-changes
Contains changes that are visible to users
label
Jun 15, 2023
…olve_source_schema
Codecov Report
@@ Coverage Diff @@
## main #10195 +/- ##
==========================================
- Coverage 70.52% 70.51% -0.01%
==========================================
Files 1255 1255
Lines 213963 213947 -16
==========================================
- Hits 150891 150860 -31
- Misses 63072 63087 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tabVersion
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type/refactor
user-facing-changes
Contains changes that are visible to users
📖✓
Covered or will be covered in the user docs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
prepare for #10214
Checklist For Contributors
./risedev check
(or alias,./risedev c
)Checklist For Reviewers
Documentation
Types of user-facing changes
Release note
** breaking changes**
Previously, users can define the primary key when creating a source or table with a connector whose schema is auto-resolved with the external format definition.
But this syntax actually does not make sense. It defines a column and a column constraint on it, which can be expressed as the relation's schema only having this column
Now we will change it to use the table constraint syntax to make it more