refactor(binder): refactor the logic to valid constraints #10192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st1page
requested review from
yuhao-su,
xiangjinwu and
BugenZhao
and removed request for
yuhao-su
Codecov Report
@@ Coverage Diff @@
## main #10192 +/- ##
==========================================
- Coverage 71.03% 71.03% -0.01%
==========================================
Files 1231 1231
Lines 210682 210686 +4
==========================================
Hits 149658 149658
- Misses 61024 61028 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
st1page
force-pushed
the
sts/refactor_bind_constraint
branch
from
d7bfef8 to
1fc4eb9
Compare
xiangjinwu
approved these changes
Jun 6, 2023
| @@ -119,6 +119,24 @@ impl ColumnIdGenerator { | |||
| } | |||
| } | |||
|
|
|||
| fn valid_column_options(c: &ColumnDef) -> Result<()> { | |||
There was a problem hiding this comment.
nit: what about naming this ensure_column_options_supported?
| .into_iter() | ||
| .map(|c| { | ||
| // All columns except `_row_id` or starts with `_rw` should be visible. | ||
| let is_hidden = c.name.starts_with("_rw"); | ||
| let is_hidden: bool = c.name.starts_with("_rw"); |
There was a problem hiding this comment.
Just curious why is this type annotation added
There was a problem hiding this comment.
I guess it is produced when copying and pasting the code. thanks!
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We have actually 2 kinds of bind error's here
This PR split them to different functions.
Checklist For Contributors
./risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note