Skip to content

Commit

Permalink
update comments
Browse files Browse the repository at this point in the history
  • Loading branch information
xzhseh committed Apr 4, 2024
1 parent d877b14 commit dbc468a
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/connector/src/sink/snowflake_connector.rs
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ impl SnowflakeHttpClient {
header: HashMap<String, String>,
s3_path: Option<String>,
) -> Self {
// TODO: ensure if we need user to *explicitly* provide the `request_id`
// todo: ensure if we need user to *explicitly* provide the `request_id`
// currently it seems that this is not important
let url = format!(
"https://{}.{}/v1/data/pipes/{}.{}.{}/insertFiles?requestId={}",
account.clone(),
Expand Down Expand Up @@ -195,7 +196,7 @@ impl SnowflakeHttpClient {
}
}

/// TODO(Zihao): refactor this part after s3 sink is available
/// todo: refactor this part after s3 sink is available
pub struct SnowflakeS3Client {
s3_bucket: String,
s3_path: Option<String>,
Expand Down

0 comments on commit dbc468a

Please sign in to comment.