fix(metrics): incorrect FP rate (#10300)

risingwavelabs · Jun 13, 2023 · 2b2ea49 · 2b2ea49
1 parent 54c660b
commit 2b2ea49
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/docker/dashboards/risingwave-dev-dashboard.json b/docker/dashboards/risingwave-dev-dashboard.json
diff --git a/docker/dashboards/risingwave-user-dashboard.json b/docker/dashboards/risingwave-user-dashboard.json
diff --git a/docs/cpu-profiling.md b/docs/cpu-profiling.md
@@ -6,13 +6,13 @@ Share an easy-to-use profiler and flamegraph tool: https://github.com/koute/not-
 Record samples:
 
 ```shell
-nperf record -p `pidof compute-node` -o perf.data`
+nperf record -p `pidof compute-node` -o perf.data
 ```
 
 Generate flamegraph: 
 
 ```shell
-nperf flamegraph perf.data > perf.svg
+nperf flamegraph --merge-threads perf.data > perf.svg
 ```
 
 ## Profiling remote compute nodes

diff --git a/grafana/risingwave-dev-dashboard.dashboard.py b/grafana/risingwave-dev-dashboard.dashboard.py
@@ -1792,7 +1792,7 @@ def section_hummock(panels):
             "False-Positive / Positive",
             [
                 panels.target(
-                    f"1 - (((sum(rate({table_metric('state_store_read_req_positive_but_non_exist_counts')}[$__rate_interval])) by (job,instance,table_id,type))) / (sum(rate({table_metric('state_store_read_req_bloom_filter_positive_counts')}[$__rate_interval])) by (job,instance,table_id,type)))",
+                    f"(((sum(rate({table_metric('state_store_read_req_positive_but_non_exist_counts')}[$__rate_interval])) by (job,instance,table_id,type))) / (sum(rate({table_metric('state_store_read_req_bloom_filter_positive_counts')}[$__rate_interval])) by (job,instance,table_id,type)))",
                     "read req bloom filter false positive rate - {{table_id}} - {{type}} @ {{job}} @ {{instance}}",
                 ),
             ],

diff --git a/grafana/risingwave-dev-dashboard.json b/grafana/risingwave-dev-dashboard.json
diff --git a/grafana/risingwave-user-dashboard.json b/grafana/risingwave-user-dashboard.json