Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to pull in latest from docs-specs-template #30

Merged
merged 1 commit into from
Mar 7, 2024
Merged

refactor to pull in latest from docs-specs-template #30

merged 1 commit into from
Mar 7, 2024

Conversation

kbroch-rivosinc
Copy link
Contributor

relates to #28

Did the following:

  • pre-commit
  • updated readme.adoc
  • source docs moved to src
  • build happens in build directory
  • add html output
  • update to latest for docs-resource submodule
  • move imagesoutdir to Makefile since docker build can't deal with ../build for wavedrom output

@ved-rivos
Copy link
Collaborator

@kbroch-rivosinc - I will be holding off merging this while the public review is ongoing for the specification.

@ved-rivos
Copy link
Collaborator

@kbroch-rivosinc - could you please help resolve the conflict?

Copy link
Collaborator

@ved-rivos ved-rivos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help address the conflict. Looks good otherwise.

relates to #28

Did the following:
* pre-commit
* updated readme.adoc
* source docs moved to src
* build happens in build directory
* add html output
* update to latest for docs-resource submodule
* move imagesoutdir to Makefile since docker build can't deal with ../build for wavedrom output

Signed-off-by: Kevin Broch <[email protected]>
@ved-rivos ved-rivos merged commit 5f38b96 into riscv:main Mar 7, 2024
2 checks passed
@ved-rivos
Copy link
Collaborator

@kbroch-rivosinc the build-specification action is not letting me pick Frozen as state for the document. The new pull down only has Draft, Stable, Release. We need all states as in Specification States - Draft, Stable, Frozen, Ratified. Could this be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants