docker: mount source and resources as read-only #1724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids writing output files into the source tree by changing the imagesoutdir variable to point at the build tree. We can bind mount source and docs-resources as read-only into the build directory and then create symlinks to ensure the docker container sees the appropriate directory layout. Note: imagesoutdir must be an absolute path since otherwise asciidoctor-mathemtical interprets it as a path relative to the source dir rather than the current working directory (asciidoctor-diagram does the expected thing and interprets it relative to the cwd).
arichardson
force-pushed
the
docker-readonly
branch
from
25880c5
to
0787da5
Compare
aswaterman
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids writing output files into the source tree by changing the imagesoutdir variable to point at the build tree. We can bind mount source and docs-resources as read-only into the build directory and then create symlinks to ensure the docker container sees the appropriate directory layout.
Note: imagesoutdir must be an absolute path since otherwise asciidoctor-mathemtical interprets it as a path relative to the source dir rather than the current working directory (asciidoctor-diagram does the expected thing and interprets it relative to the cwd).