Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor typo in PTE section #433

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Fix minor typo in PTE section #433

merged 1 commit into from
Oct 29, 2024

Conversation

Timmmm
Copy link
Contributor

@Timmmm Timmmm commented Oct 24, 2024

what -> that, and I think "known to not contain" is a bit easier to parse than "known not to contain".

what -> that, and I think "known to not contain" is a bit easier to parse than "known not to contain".

Signed-off-by: Tim Hutt <[email protected]>
@jrtc27
Copy link
Collaborator

jrtc27 commented Oct 24, 2024

Splitting infinitives can be a contentious subject. Some might also prefer "which" to "that", at least in British English, though in this instance it seems American English prescribes "that".

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the what->that makes the sentence easier to parse. No opinion on the not to -> to not.

@tariqkurd-repo tariqkurd-repo merged commit 86417e4 into riscv:main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants