Indicate GCMODE output for non-X caps #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this doesn't include reserved bits being non-zero, or GCTYPE which has the same problem |
It is generally not a policy for these getter instruction's output to be dependent on whether the input capability is corrupted or not. It would be best to keep this idea, otherwise we will need to change other instructions like GCLEN, GCTYPE, GCPERM, ACPERM, etc to conform |
tariqkurd-repo
approved these changes
Sep 20, 2024
arichardson
approved these changes
Sep 20, 2024
tariqkurd-repo
pushed a commit
to tariqkurd-repo/riscv-cheri
that referenced
this pull request
Oct 9, 2024
Change the specification for GCMODE so that it returns 0 when the input capability goes not have the X permission set. Fixes riscv#376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the specification for GCMODE so that it returns 0 when the input capability goes not have the X permission set.
Fixes #376