Replace references to T8 with L8 in the bounds encoding, and provide … #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld contains bit 8 of the length. Which is used to compute then top field for the capability. Resolves issue #(290)
buxtonpaul
force-pushed
the
rv32_bounds_l8
branch
from
980cd6a
to
daa92d3
Compare
|
I have re-pushed to the branch fixing both the length typo as well as any line ending issues(I hope) |
I don't see another commit?! |
|
It was an amend commit which replaced the original |
andresag01
approved these changes
Jun 20, 2024
|
@PeterRugg : Would you like to take a look at these changes? |
|
Yep, looks like the right fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The field T8 is named incorrectly and should be L8 to indicate the field contains bit 8 of the length. Which is used to compute then top field for the capability.
Resolves issue #(290) #290