Clarify bit-slices in edge cases of the decoded bound figure #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresag01
approved these changes
May 3, 2024
There was a problem hiding this comment.
Change looks good. I agree with @tariqkurd-repo that it would be good to describe when/why the "upper section" disappears.
tariqkurd-repo
pushed a commit
to tariqkurd-repo/riscv-cheri
that referenced
this pull request
May 8, 2024
@tariqkurd-repo pointed out that the table was slightly wrong in big exponent cases (negative-width bit-slices). This fixes it while hopefully not making it too much more confusing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tariqkurd-repo pointed out that the table was slightly wrong in big exponent cases (negative-width bit-slices). This fixes it while hopefully not making it too much more confusing!