Fix various Zba bugs #160
Merged
Fix various Zba bugs #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it match with the other UW encodings and what's in riscv-opcodes.
I think the mistake was that it was {4'he, 2'h3}
arichardson
approved these changes
Mar 29, 2024
andresag01
approved these changes
Apr 2, 2024
…t in-line with CSV
|
@PRugg-Cap this is the source of the CSV file: https://docs.google.com/spreadsheets/d/1PsWkaqRM2PiXKl7f9EegCjEsb4CVuvnZdIeJeFPyBDw/edit#gid=0 I made the changes there and reimported by running |
|
@veselypeta opinion? |
|
LGTM :) |
|
It would have been good to include the specific bugs that were fixed in the commit message or use rebase and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159