Redundant pcc unseal text #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislaus
suggested changes
Feb 21, 2024
There was a problem hiding this comment.
This does not match the result of the discussion in #112 if I understand your PR correctly.
|
@francislaus this PR is saying that there can't be an exception caused by the PCC being sealed, so I've removed that from the exception table |
|
I think it might be better to add a note that this check is architecturally required but with the current definition of Zcheri_purecap is not possible at runtime, so implementations can choose to omit it. |
andresag01
approved these changes
Feb 23, 2024
arichardson
reviewed
Feb 23, 2024
arichardson
approved these changes
Feb 23, 2024
Co-authored-by: Alexander Richardson <[email protected]> Signed-off-by: Tariq Kurd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove redundant exception check for the PCC being sealed