Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes and formatting changes #11

Merged
merged 8 commits into from
Jan 24, 2024
Merged

Conversation

PeterRugg
Copy link
Contributor

Just very minor edits noticed by Franz and me as we read through.

Copy link
Collaborator

@tariqkurd-repo tariqkurd-repo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one typo, otherwise LGTM

Copy link
Collaborator

@arichardson arichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the CW change. Maybe expanding "this feature" avoids the ambiguity?

Copy link
Collaborator

@andresag01 andresag01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review and changes! I will re-run CI and merge if passes since everyone seems happy with the change!

@andresag01 andresag01 merged commit 859135c into riscv:main Jan 24, 2024
1 check passed
arichardson pushed a commit to arichardson/riscv-cheri that referenced this pull request Jan 30, 2024
Updates to fix the build issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants