Complete PMP configuration CSRs and address CSRs are not supported for 64 PMP entries

[Abdulwadoodd]

Arch-tests do not have the support of following CSRs in encoding.h file.

• pmpcfgx where x is [4,15]
• pmpaddrx where x is [16,63]

[allenjbaum]

I'm going to question why arch-test has it's own encoding.h file, instead of just getting it from a separate "official architectural repository.
That really should be in the riscv/ repo, but the version that is there (opcodes/encoding.h) is not complete (it doesn;t even mention PMPADDR or PMPCFG at all).
The most up-to-date one is in the riscv-software-src/riscv-isa-sim/ repo, in file
riscv/encoding.h
This should get fixed properly; maintaining separate copies is not a good thing.

[Abdulwadoodd]

Little correction: The file present by default in riscv/riscv-opcodes is not complete but the most up-to-date version (even latest than what is in riscv-isa-sim/riscv) of the file can be generated by running make in riscv/riscv-opcodes.

[allenjbaum]

I've filed an issue to try to ensure that the version in the repository is always the latest.
The question is how the framework pulls it in, or should the framework always regenerate it as you did
In either case it doesn't need to be in the repo at all.

[Abdulwadoodd]

According to Andrew's comment on your issue (here), for now we need to regenerate it every time. How about writing a makefile that clone riscv/riscv-opcodes and build encoding.h locally to place in riscv-arch-test/riscv-test-suite/env. What do you say

[allenjbaum]

We could either - 1. clone it as you said - 2. add a CI script to the riscv-opcodes repo to produce it as a release and simply copy it from as part of make - 3.copy it from the spike directory. Short term, your solution is best. Longer term: I'd like to see the CI script solution so others can use the same approach, if that is possible

…

On Thu, Jun 30, 2022 at 8:30 AM Wadood ***@***.***> wrote: According to Andrew's comment on your issue (here <riscv/riscv-opcodes#132 (comment)>) for now, we need to regenerate it every time. How about writing a makefile that clone riscv/riscv-opcodes <https://github.com/riscv/riscv-opcodes> riscv/riscv-opcodes <https://github.com/riscv/riscv-opcodes> and build encoding.h locally to place in riscv-arch-test/riscv-test-suite/env <https://github.com/riscv-non-isa/riscv-arch-test/tree/main/riscv-test-suite/env>. What do you say — Reply to this email directly, view it on GitHub <#263 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHPXVJVWF3XLN643QU4AAITVRW4RXANCNFSM52GJRZCQ> . You are receiving this because you commented.Message ID: ***@***.***>

[Abdulwadoodd]

Hi @allenjbaum, I have implemented a long-term solution by writing a CI script. Kindly review PR #268