target/riscv: Fix memory access when MMU is enabled and address couldn't be translated #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kr-sc
force-pushed
the
kr-sc/fix-mmu-access-upstream
branch
from
9687679 to
3122c69
Compare
timsifive
requested changes
Oct 25, 2023
src/target/riscv/riscv.c
Outdated
| LOG_TARGET_ERROR(target, "Failed to read vsatp register."); | ||
| int result = riscv_get_register(target, &vsatp, GDB_REGNO_VSATP); | ||
| if (result != ERROR_OK) { | ||
| LOG_TARGET_ERROR(target, "Failed to read vsatp register. Error: %d", result); | ||
| return ERROR_FAIL; |
There was a problem hiding this comment.
Suggested change
| return ERROR_FAIL; | |
| return result; |
There was a problem hiding this comment.
After internal discussion we decided not to print/return error code here, because it looks like useless for users.
src/target/riscv/riscv.c
Outdated
| LOG_TARGET_ERROR(target, "Failed to read hgatp register."); | ||
| result = riscv_get_register(target, &hgatp, GDB_REGNO_HGATP); | ||
| if (result != ERROR_OK) { | ||
| LOG_TARGET_ERROR(target, "Failed to read hgatp register. Error: %d", result); | ||
| return ERROR_FAIL; |
There was a problem hiding this comment.
Suggested change
| return ERROR_FAIL; | |
| return result; |
There was a problem hiding this comment.
Same comment as above
kr-sc
force-pushed
the
kr-sc/fix-mmu-access-upstream
branch
from
3122c69 to
24de36b
Compare
…n't be translated Now: 1) If mmu is disabled, virt2phys succeeded and returns physical address 2) If mmu is enbaled, but translation fails, read/write_memory fails Change-Id: I312309c660239014b3278cb77cadc5618de8e4de Signed-off-by: Kirill Radkin <[email protected]>
kr-sc
force-pushed
the
kr-sc/fix-mmu-access-upstream
branch
from
24de36b to
57c3f0d
Compare
timsifive
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now:
Change-Id: I312309c660239014b3278cb77cadc5618de8e4de