Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix esp RISC-V configs #1204

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from
Open

Conversation

sobuch
Copy link
Contributor

@sobuch sobuch commented Jan 13, 2025

Seems to be broken since 6a27d9f, with the following error:

tcl//target/esp_common.cfg:69: Error: Command/target: riscv Exists
Traceback (most recent call last):
  File "tcl//target/esp32c6.cfg", line 142, in script
    create_esp_target riscv
  File "tcl//target/esp_common.cfg", line 79, in create_esp_target
    create_openocd_targets
  File "tcl//target/esp_common.cfg", line 69, in create_openocd_targets
    {target create} riscv riscv -chain-position riscv.cpu -coreid 0 -rtos hwthread

@aap-sc
Copy link
Collaborator

aap-sc commented Jan 13, 2025

@sobuch are you sure that 6a27d9f is the right commit? Looking at the diff alone it does not look like this configuration is affected.

@aap-sc
Copy link
Collaborator

aap-sc commented Jan 13, 2025

Looking at the diff alone it does not look like this configuration is affected.

actually... Maybe this line is to blame:

# .../riscv/startup.tcl
proc riscv {cmd args} {
	tailcall "riscv $cmd" {*}$args
}

@en-sc , given that you are the author of this specific code - could you take a look please?

Fixes tcl configs to enable esp RISC-V boards

Signed-off-by: Samuel Obuch <[email protected]>
@sobuch sobuch force-pushed the esp-riscv-cfg-fix branch from 16f6f1e to fb16cb5 Compare January 13, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants