target/riscv: move the dcsr modification out of program buffer #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lz-bro
force-pushed
the
enable-hardware-translation
branch
from
83bd140 to
46e3fe5
Compare
aap-sc
reviewed
Dec 24, 2024
src/target/riscv/riscv-013.c
Outdated
| if (register_read_direct(target, &dcsr, GDB_REGNO_DCSR) != ERROR_OK) | ||
| return ERROR_FAIL; | ||
|
|
||
| /* dcsr.mprven <- 0 */ |
There was a problem hiding this comment.
why do you set the filed to zero unconditionally ? should not we preserve the original value?
There was a problem hiding this comment.
riscv_program_load_mprv() set the dcsr.mprven to zero unconditionally, and I followed its logic. If I set riscv virt2phys_mode back to sw, dcsr.mprven should set to zero?
There was a problem hiding this comment.
should not we preserve the original value?
Strictly speaking, I don't think we should -- dcsr value is managed by the debugger exclusively. Though either approach should work just fine.
lz-bro
force-pushed
the
enable-hardware-translation
branch
2 times, most recently
from
67516c3 to
af1b33a
Compare
en-sc
previously approved these changes
Dec 25, 2024
lz-bro
force-pushed
the
enable-hardware-translation
branch
from
af1b33a to
5c47203
Compare
en-sc
previously approved these changes
Dec 25, 2024
when riscv virt2phys_mode is hw, reduce the use of unnecessary program buffers.
lz-bro
force-pushed
the
enable-hardware-translation
branch
from
5c47203 to
1390357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When riscv virt2phys_mode is hw, reduce the use of unnecessary program buffers. See #1188 for the original issue.