Skip to content

refactor: Overhaul

refactor: Overhaul #59

Triggered via pull request August 15, 2023 14:37
Status Failure
Total duration 19m 59s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

4 errors
[clippy] primitives/src/trie/account.rs#L46: primitives/src/trie/account.rs#L46
error: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true --> primitives/src/trie/account.rs:46:1 | 46 | impl Into<AccountInfo> for TrieAccount { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into = note: `-D clippy::from-over-into` implied by `-D warnings` help: replace the `Into` implentation with `From<trie::account::TrieAccount>` | 46 ~ impl From<TrieAccount> for AccountInfo { 47 ~ fn from(val: TrieAccount) -> Self { 48 | AccountInfo { 49 ~ balance: val.balance, 50 ~ nonce: val.nonce, 51 ~ code_hash: to_revm_b256(val.code_hash), |
clippy
reviewdog exited with status code: 1
test
The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
test
The operation was canceled.