[FEAT] Logout: Auto logout from IDS on logout

src/js/controllers/app.controller.js

@@ -772,7 +772,7 @@ function AppCtrl ($scope, id, net, keychain, txQueue, appManager, rpTracker,
 
   $scope.logout = function () {
     id.logout();
-    location.reload();
+    location.href = Options.ids_url + '/auth/logout?redirect=' + encodeURIComponent(location.href);
   };
 
   $scope.$on('$idRemoteLogout', handleRemoteLogout);

src/js/services/id.service.js

@@ -6,19 +6,14 @@
  * The id service is used for user identification and authorization.
  */
 
-var util = require('util'),
-    webutil = require('../util/web'),
-    settings = require('../util/settings'),
-    Base58Utils = require('../util/base58'),
-    RippleAddress = require('../util/types').RippleAddress;
+var webutil = require('../util/web'),
+    settings = require('../util/settings');
 
 var module = angular.module('id', ['authflow', 'blob']);
 
 module.factory(
-  'rpId', ['$rootScope', '$location', '$route', '$routeParams', '$timeout',
-  'rpAuthFlow', 'rpBlob', '$q',
-  function($scope, $location, $route, $routeParams, $timeout,
-                                 $authflow, $blob, $q) {
+  'rpId', ['$rootScope', '$location', '$route', '$routeParams', '$timeout', 'rpAuthFlow', 'rpBlob', '$q',
+  function($scope, $location, $route, $routeParams, $timeout, $authflow, $blob, $q) {
     /**
      * Identity manager
      *
@@ -350,8 +345,7 @@ module.factory(
       });
     };
 
-    Id.prototype.logout = function()
-    {
+    Id.prototype.logout = function() {
       store.remove('backend_token');
 
       // TODO make it better
@@ -373,7 +367,9 @@ module.factory(
 
     Id.prototype.unlock = function(username, password, callback) {
       // Callback is optional
-      if('function' !== typeof callback) callback = $.noop;
+      if ('function' !== typeof callback) {
+        callback = $.noop;
+      }
 
       // username = Id.normalizeUsernameForDisplay(username);
       // password = Id.normalizePassword(password);
@@ -393,7 +389,7 @@ module.factory(
      * Redirects the user to a page where they can identify. This could be the
      * login tab most likely.
      */
-    Id.prototype.goId = function () {
+    Id.prototype.goId = function() {
       if (!this.isLoggedIn()) {
         if (_.size($routeParams)) {
           var tab = $route.current.tabName;
@@ -421,9 +417,6 @@ module.factory(
       return this.resolvedNames[address];
     };
 
-    /**
-     *
-     */
     Id.prototype.addressDontHaveName = function(address) {
       return this.resolvedNames[address] === address;
     };

src/js/tabs/login.controller.js

@@ -1,10 +1,9 @@
-
+'use strict';
 
 var util = require('util');
 var Tab = require('../client/tab').Tab;
 
-var LoginTab = function()
-{
+var LoginTab = function() {
   Tab.call(this);
 };
 

src/less/ripple/content.less

@@ -2,7 +2,7 @@
 
 // Temporary
 @media (max-width: @screen-xs-max) {
-  .t-login, .t-register, .t-migrate, .t-tou, .t-privacypolicy {
+  .t-login, .t-tou, .t-privacypolicy {
     header {
       display: none;
     }

src/less/ripple/landing.less

@@ -148,24 +148,24 @@ header.loggedOut {
 		}
 	}
 
-	#t-register .auth-form-container .auth-form-wrapper, #t-login .auth-form-container .auth-form-wrapper, #t-recover .auth-form-container .auth-form-wrapper, #t-account .auth-form-container .auth-form-wrapper, #t-migrate .auth-form-container .auth-form-wrapper {
+	#t-login .auth-form-container .auth-form-wrapper, #t-account .auth-form-container .auth-form-wrapper {
 		float: right;
 		border: none;
 		background: rgba(76, 141, 184, .8);
 		border-radius: 5px;
 	}
 
-	#t-register .auth-form-container h2, #t-login .auth-form-container h2, #t-recover .auth-form-container h2, #t-account .auth-form-container h2, #t-migrate .auth-form-container h2 {
+	#t-login .auth-form-container h2, #t-account .auth-form-container h2 {
 		color: @white;
 		width: 100%;
 		margin: 0;
 	}
 
-	#t-register .auth-form-container .auth-form-wrapper label, #t-login .auth-form-container .auth-form-wrapper label, #t-recover .auth-form-container .auth-form-wrapper label, #t-account .auth-form-container .auth-form-wrapper label, #t-migrate .auth-form-container .auth-form-wrapper label, #t-register .auth-form-container .see-privacy-text, #t-login .auth-form-container .see-privacy-text, #t-recover .auth-form-container .see-privacy-text, #t-account .auth-form-container .see-privacy-text, #t-migrate .auth-form-container .see-privacy-text {
+	#t-login .auth-form-container .auth-form-wrapper label, #t-account .auth-form-container .auth-form-wrapper label, #t-login .auth-form-container .see-privacy-text, #t-account .auth-form-container .see-privacy-text {
     color:  @landingblue;
 	}
 
-	#t-register .auth-form-container .sign-up-steps-list li.active, #t-login .auth-form-container .sign-up-steps-list li.active, #t-recover .auth-form-container .sign-up-steps-list li.active, #t-account .auth-form-container .sign-up-steps-list li.active, #t-migrate .auth-form-container .sign-up-steps-list li.active {
+	#t-login .auth-form-container .sign-up-steps-list li.active, #t-account .auth-form-container .sign-up-steps-list li.active {
 		color: @white;
 		border-bottom: 1px solid @white !important;
 	}
@@ -421,31 +421,6 @@ header.loggedOut {
 
 }
 
-//register specific
-#t-register {
-
-	h2.loginTop a {
-		color: @midgray !important;
-		display: block;
-		background: rgba(0,0,0,0.2);
-		padding: 15px;
-		&:hover {
-			color: @white !important;
-		}
-	}
-
-	.tabBg {
-		background: rgba(0,0,0,.6);
-		height: 100px;
-		width: 16%;
-		position: absolute;
-		right: 15px !important;
-		border-top-right-radius: 5px;
-		cursor: pointer;
-	}
-
-}
-
 //privacy policy and tou
 .t-privacypolicy, .t-tou {
 

src/less/ripple/tabs/authorization.less

@@ -1,9 +1,9 @@
-.t-register, .t-login, .t-recover, .t-migrate {
+.t-login {
     header nav {
         display: none;
     }
 }
-#t-register, #t-login, #t-recover, #t-account, #t-migrate {
+#t-login, #t-account {
     a {
         text-decoration: none;
         &:hover, &:focus {
@@ -238,56 +238,7 @@
         }
     }
 }
-#t-register {
-    .auth-form-container {
-        &.mode-verification {
-            .auth-form-wrapper {
-                .btn-cancel {
-                    .loading_text {
-                        text-transform: lowercase;
-                    }
-                }
-            }
-        }
-    }
-    .register_masterkey {
-        position: relative;
-        .auth-attention {
-            margin-top: 30px;
-            text-align: center;
-            .recovery {
-                margin-top: 10px;
-            }
-        }
-    }
-    .welcome-wrapper {
-        text-align: center;
-    }
-    .platform, h4.new {
-        max-width: 700px;
-        margin: auto;
-    }
-    h4.new {
-        padding: 25px 0;
-        border-top: 1px solid @midgray;
-        font-weight: 200;
-        font-size: 1.1em;
-    }
-    span.currency {
-        font-weight: 500;
-    }
-    .xrp-xau {
-        font-size: 1.2em;
-    }
-}
-#t-migrate {
-    .text-status {
-        #error {
-            font-size: 12px;
-            color: @midred;
-        }
-    }
-}
+
 #t-login {
     @media (max-width: @screen-xs-max) {
         .content {

src/templates/tabs/login.jade

@@ -19,17 +19,7 @@ section.col-xs-12.content(ng-controller="LoginCtrl")
             span(l10n) Sign Up
           button.btn.btn-submit.btn-block.btn-success#loginBtn(type="submit" ng-click="submitForm('login')")
             span(l10n) Sign In
-        .input-group.col-xs-12
           input(name='redirect_to', type='hidden', value='{{redirectTo}}')
-          label
-            input.rememberMe(name='remember_me', type='checkbox')
-            span(for='remember_me', l10n) Remember me on this device for 30 days
-      .row.switch-mode-wrapper
-        .switch-mode-link-container.bottomText(l10n)
-          | Ripple Trade uses  
-          a(href="https://id.ripple.com") RippleID  
-          | to securely manage your personal information
-
 
   .row.action-login(ng-if="$routeParams.to")
     .col-xs-12.col-sm-6.col-md-6.uri-form-container

src/templates/tabs/security.jade

@@ -36,8 +36,8 @@ section.col-xs-12.content(ng-controller="SecurityCtrl")
           .section
             .descriptor(l10n) Security settings
             .row
-            label(l10n) You can now manage your secret settings such as secret key, password,
-                |  and two-factor authentication through Ripple ID. Pressing edit will take you to id.ripple.com.
+            label(l10n) You can now manage your security settings such as secret key,
+                |  password, and two-factor authentication by clicking edit.
             .row.row-padding-small-xs
               .col-xs-9.col-sm-8.col-md-6
               .col-xs-3.col-sm-4.col-md-6

test/selenium/tests-public/LoginRT.json

@@ -60,6 +60,11 @@
       "type": "waitForTextPresent",
       "text": "BALANCES"
     },
+    {
+      "type": "waitForTextPresent",
+      "text": "Connected to BrowserSync",
+      "negated": true
+    },
     {
       "type": "clickElement",
       "locator": {

test/travis/config-travis.js

@@ -5,7 +5,6 @@
  */
 var Options = {
   // Local domain
-  //
   // Which domain should ripple-client consider native?
   domain: 'ripp.site:3000',
 
@@ -85,7 +84,7 @@ var Options = {
   gateway_max_limit: 1000000000,
 
   // Ripple trade backend URL
-  backend_url: 'http://54.68.38.81:8080',
+  backend_url: 'http://54.68.38.81:8081',
   ids_url: 'http://idripple.com',
 
   ticker: {