Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

[FIX] Trade: Show loading for orderbooks(RT-3402) #2497

Merged
merged 2 commits into from
May 11, 2015

Conversation

darkdarkdragon
Copy link
Contributor

Orderbook: Show loading instead of "no bids"

@darkdarkdragon
Copy link
Contributor Author

before
rt-3402-before

@darkdarkdragon
Copy link
Contributor Author

after
rt-3402-after

@vhpoet
Copy link
Contributor

vhpoet commented May 6, 2015

@darkdarkdragon can you make it centered, so that it doesn't touch the borders?

@darkdarkdragon
Copy link
Contributor Author

@vhpoet done
rt-3402-after2

@mrajvanshy
Copy link
Contributor

LGTM

@vhpoet
Copy link
Contributor

vhpoet commented May 7, 2015

@darkdarkdragon it's still touching the bottom side.

@darkdarkdragon
Copy link
Contributor Author

@vhpoet fixed
rt-3402-after3

@mynetx
Copy link
Contributor

mynetx commented May 8, 2015

LGTM

1 similar comment
@vhpoet
Copy link
Contributor

vhpoet commented May 11, 2015

LGTM

mrajvanshy added a commit that referenced this pull request May 11, 2015
[FIX] Trade: Show loading for orderbooks(RT-3402)
@mrajvanshy mrajvanshy merged commit d3359d3 into ripple:release May 11, 2015
@darkdarkdragon darkdarkdragon deleted the release-RT-3402 branch May 30, 2015 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants