This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[FIX] Send: fix currencies constraints (RT-3393) #2482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix processing of currencies constraints. When RT is loaded in browser, underscore lib gets replaced by the lodash by something. And in the old versions of lodash there was bug in _.intersection method (if argument is just one array it returned this array). But in recent versions they fixed this bug, so $scope.update_currency_choices broke.
|
LGTM |
1 similar comment
|
LGTM |
MatthewPhinney
added a commit
that referenced
this pull request
May 1, 2015
[FIX] Send: fix currencies constraints (RT-3393)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix processing of currencies constraints.
When RT is loaded in browser, underscore lib gets replaced
by the lodash by something. And in the old versions of lodash
there was bug in _.intersection method (if argument is just one
array it returned this array). But in recent versions they fixed
this bug, so $scope.update_currency_choices broke.