Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

[FIX] Advanced Trade: remove one step (RT-3271) #2472

Merged
merged 2 commits into from
May 6, 2015

Conversation

darkdarkdragon
Copy link
Contributor

Do not show "Submit another order" screen
after placing an order

Do not show "Submit another order" screen
after placing an order
@darkdarkdragon
Copy link
Contributor Author

before
rt-3271-before

@darkdarkdragon
Copy link
Contributor Author

after
rt-3271-after

@yongsoo
Copy link
Contributor

yongsoo commented Apr 29, 2015

Do we want the module to move? I'm assuming the notification will disappear. What if the user is trying to click and do a click trade but the notification moves? Maybe we should move the notification to a place where it won't move the input fields? @vhpoet

@vhpoet
Copy link
Contributor

vhpoet commented Apr 29, 2015

@yongsoo makes a lot of sense.

@yongsoo
Copy link
Contributor

yongsoo commented May 4, 2015

@darkdarkdragon What do you think?

@darkdarkdragon
Copy link
Contributor Author

@yongsoo Sounds reasonable. I'll move it under input fields

move order notification under order widget
@darkdarkdragon
Copy link
Contributor Author

moved:
rt-3271-after2

@vhpoet
Copy link
Contributor

vhpoet commented May 6, 2015

LGTM

1 similar comment
@mrajvanshy
Copy link
Contributor

LGTM

mrajvanshy added a commit that referenced this pull request May 6, 2015
[FIX] Advanced Trade: remove one step (RT-3271)
@mrajvanshy mrajvanshy merged commit e3871ab into ripple:develop May 6, 2015
@darkdarkdragon darkdarkdragon deleted the develop-RT-3271 branch May 6, 2015 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants