This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[FIX] Advanced trade: fix values calculations #2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@geertweening @clark800 do you guys know what needs to be fixed? |
|
He's referring to this pull request: XRPLF/xrpl.js#326 |
|
@vhpoet just come to my mind - why to_text_full was used here in the first place? |
Do not convert amount and order values to number when assigning to input - because chrome and IE shows big/small numbers in input in scientific notation use "replace(/,/g, '')" on result of "to_text_full()" until ripple lib fixed - "to_text_full()" returns string with group separator
darkdarkdragon
force-pushed
the
develop-fix-trade-input
branch
from
7c5ec25
to
a49edc3
Compare
| @@ -834,7 +836,7 @@ TradeTab.prototype.angular = function(module) | |||
| if (order.price_amount && order.price_amount.is_valid() && | |||
| order.first_amount && order.first_amount.is_valid()) { | |||
| order.second_amount = order.price_amount.product_human(order.first_amount); | |||
| order.second = +order.second_amount.to_human({group_sep: false}); | |||
| order.second = order.second_amount.to_human({group_sep: false}); | |||
There was a problem hiding this comment.
Why was the + killed? It's a conversion to number.
There was a problem hiding this comment.
@jublo That was whole point of this commit. This value goes into input field. And when it is number, chrome shows it in e-notation if it too small or too big
There was a problem hiding this comment.
Understood. Well done then.
|
LGTM |
1 similar comment
|
LGTM |
mrajvanshy
added a commit
that referenced
this pull request
Apr 29, 2015
[FIX] Advanced trade: fix values calculations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not convert amount and order values to number
when assigning to input - because chrome and IE shows
big/small numbers in input in scientific notation
use "replace(/,/g, '')" on result of "to_text_full()"
until ripple lib fixed - "to_text_full()" returns
string with group separator