This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
[FIX] fix parsing incoming trust lines #2154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
show Rippling for incoming trust lines? where do you show a rippling for incomings? |
|
|
|
Does this mean the "Rippling" is sometimes showing the incoming rippling and sometimes the outgoing one? |
src/js/util/jsonrewriter.js
Outdated
| effect.limit = ripple.Amount.from_json(viewHigh ? high : low); | ||
| effect.limit_peer = ripple.Amount.from_json(viewHigh ? low : high); | ||
|
|
||
| effect.type = obj.transaction.type == 'trusting' ? 'trust_create_local' : 'trust_create_remote'; |
JsonRewriter: correctly parse limit, limit_peer and noRipple properties of incoming trust line transaction Trust Tab: correctly show "Rippling" field for incoming trust lines
darkdarkdragon
force-pushed
the
develop-fix-trust-line-parsing
branch
from
6aa096e
to
7de0e1b
Compare
|
@vhpoet It is one table for all trust lines - incoming and outgoing. But "Rippling" column shows incorrect data for incoming trustilines |
vhpoet
force-pushed
the
develop
branch
2 times, most recently
from
f095e33
to
9768d18
Compare
redredgroovy
force-pushed
the
develop
branch
3 times, most recently
from
5a8046b
to
dc6dbb4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JsonRewriter: correctly parse limit, limit_peer and noRipple properties of
incoming trust line transaction
Trust Tab: correctly show "Rippling" field for incoming trust lines