Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amendment related pages styling updates + bugs fixes #875

Open
pdp2121 opened this issue Nov 17, 2023 · 0 comments
Open

Amendment related pages styling updates + bugs fixes #875

pdp2121 opened this issue Nov 17, 2023 · 0 comments
Assignees
@pdp2121
Labels
design work needed This issue requires some UI design work

Comments

@pdp2121
Copy link
Collaborator

pdp2121 commented Nov 17, 2023

Address the following changes to the pages:

  • Align dropdown items in the NavBar to the right.
  • Increase font weight for the right labels of the Amendment Summary page.
  • Fix vnull issue on Amendment Summary rippled version.
  • Add an ETA to indicate the time amendment would be enabled for ones that has more than 80% votes.
  • Highlight color for amendments more than 80% on Amendments List page
  • Reduce the font size for Yays Nays to match the top of the page.
  • The y-axis of the graph should show percentage instead of count.
  • Make Enabled column all caps.
  • Rename Voters column to UNL Voters.
  • Rename Enabled (on) to Enabled on.
  • rippled version linked to rippled release for that version.
  • The details link should open a new tab.
  • Yays and Nays validators should link to the validator page on the Explorer.
  • Capitalize the labels on Validator's Voting page.
  • Fix loader timing issue on Amendments List page.
  • Make Nays list magneta.
  • tx column renamed to Enable tx

Optional change:

  • Make a line of 80% for the graph to indicate threshold.
  • Make different tabs for graph, simple, and Yays Nays for Amendment summary.
  • Make the header row sticky for the list table.
@pdp2121 pdp2121 self-assigned this Nov 17, 2023
@pdp2121 pdp2121 mentioned this issue Nov 20, 2023
Merged
25 tasks
pdp2121 added a commit that referenced this issue Nov 28, 2023
@pdp2121
fix: amendments pages styling updates (#878)
5c3150e 
## High Level Overview of Change

<!--
Please include a summary/list of the changes.
If too broad, please consider splitting into multiple PRs.
-->

Address #875

- [x] Align dropdown items in the NavBar to the left.
- [x] Increase font weight for the right labels of the Amendment Summary
page.
- [x] Fix vnull issue on Amendment Summary rippled version.
- [x] Add an ETA to indicate the time amendment would be enabled for
ones that has more than 80% votes.
- [x] Highlight color for amendments more than 80% on Amendments List
page
- [x] Reduce the font size for Yays Nays to match the top of the page.
- [x] The y-axis of the graph should show percentage instead of count.
- [x] Make Enabled column all caps.
- [x] Rename Voters column to UNL Voters.
- [x] Rename Enabled (on) to Enabled on.
- [x] rippled version linked to rippled release for that version.
- [x] The details link should open a new tab.
- [x] Yays and Nays validators should link to the validator page on the
Explorer.
- [x] Capitalize the labels on Validator's Voting page.
- [x] Fix loader timing issue on Amendments List page.
- [x] tx column renamed to Enable tx
- [x] sort to have amendments with eta on top of the amendments list

### Context of Change

<!--
Please include the context of a change.
If a bug fix, when was the bug introduced? What was the behavior?
If a new feature, why was this architecture chosen? What were the
alternatives?
If a refactor, how is this better than the previous implementation?

If there is a design document for this feature, please link it here.
-->

### Type of Change

<!--
Please check relevant options, delete irrelevant ones.
-->

- [x] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (non-breaking change that only restructures code)
- [ ] Tests (You added tests for code that already exists, or your new
feature included in this PR)
- [ ] Documentation Updates
- [ ] Translation Updates
- [ ] Release

## Before / After
### Amendments List Page
![Screenshot 2023-11-20 at 8 18 30
PM](https://github.com/ripple/explorer/assets/71317875/6b0bd5dd-c698-49a3-8260-deb9a8b182b0)

### Amendment Summary Page
#### Simple

![Screenshot 2023-11-20 at 8 32 43
PM](https://github.com/ripple/explorer/assets/71317875/b0af8ca7-b98f-40d5-9142-d17a83ae7ebb)

#### Graph
![Screenshot 2023-11-27 at 2 18 58
PM](https://github.com/ripple/explorer/assets/71317875/b9468589-9ee0-46a7-892a-2c215dae7486)


#### Yeas/Nays

![Screenshot 2023-11-20 at 8 33 31
PM](https://github.com/ripple/explorer/assets/71317875/7d67965b-3f4c-489e-b83f-ebf98d0b9df1)

### Validator's Voting Tab

![Screenshot 2023-11-20 at 8 55 27
PM](https://github.com/ripple/explorer/assets/71317875/961bb090-e150-4ec8-9c6e-5fc9dd050342)
@mvadari mvadari mentioned this issue Dec 2, 2023
Merged
1 task
mvadari added a commit that referenced this issue Dec 4, 2023
@mvadari
fix: add link from EnableAmendment tx to amendment page (#892)
1f34ff1 
## High Level Overview of Change

Title says it all.

### Context of Change

Ties in with #875 

### Type of Change

- [x] Bug fix (non-breaking change which fixes an issue)

### TypeScript/Hooks Update

N/A

## Test Plan

Added test. CI passes + works locally.
@mvadari mvadari added the design work needed This issue requires some UI design work label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pdp2121 pdp2121

Labels
design work needed This issue requires some UI design work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvadari @pdp2121