Adding slot for arrow icon #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will give the flexibility to change the arrow icon of the select box (many design teams ask for it) closing issue riophae#322 in a more elegant way than the other PR suggested.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #473 +/- ##
==========================================
- Coverage 97.68% 97.32% -0.37%
==========================================
Files 27 27
Lines 1037 1046 +9
Branches 104 106 +2
==========================================
+ Hits 1013 1018 +5
- Misses 9 11 +2
- Partials 15 17 +2 ☔ View full report in Codecov by Sentry. |
kevinvermeersch
pushed a commit
to hoooxnv/vue-treeselect
that referenced
this pull request
Jan 18, 2023
|
@riophae Hi! Can merge this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will give the flexibility to change the arrow icon of the select box (many design teams ask for it) closing issue #322
adding a custom slot names arrow-icon to the main arrow.
also adding same logic to the children arrows