feat: add build CI for windows #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I will check citiespy’s Windows build. Track here ringsaturn/go-cities.json#12 |
when approve I will change the version in |
ringsaturn
pushed a commit
to ringsaturn/tzf-rs
that referenced
this pull request
Jan 25, 2023
|
@yihong0618 Please bump tzf-rs to v0.2.1 |
|
test added waiting for |
|
citiespy Windows support is ready: 0.3.3 |
ringsaturn
reviewed
Jan 25, 2023
ringsaturn
reviewed
Jan 25, 2023
|
@ringsaturn https://github.com/yihong0618/tzfpy/actions/runs/4003888133 do I need to rebase all commits or you just squash ? |
ringsaturn
approved these changes
Jan 25, 2023
|
It’s ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
running_page use tzfpy now, and we found it does not support windows.
pprof can not compile on windows.