Make clap an optional dependency #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ringsaturn
reviewed
May 7, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 3 3
Lines 176 176
=======================================
Hits 128 128
Misses 48 48 ☔ View full report in Codecov by Sentry. |
wildwestrom
changed the title
ringsaturn
reviewed
May 7, 2023
| Or put in your `Cargo.toml` file: | ||
|
|
||
| ```toml | ||
| tzf-rs = { version = "0.4.0", default-features = false } |
There was a problem hiding this comment.
I will try this in tzfpy, and will merge this PR if everything is fine:
tzf-rs = { git = "https://github.com/wildwestrom/tzf-rs", rev = "6e523af", default-features = false}
|
Awesome, should I wait for the next semver version to see these changes? |
I have release It has been deployed to https://crates.io/crates/tzf-rs/0.4.1 |
|
Thank you very much. |
|
The readme should be updated to reflect the new version as well. |
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make clap an optional dependency if I just want to install the library, while also keeping the ability to use
cargo installto install the binary.