fix: Compatibility fixes

rindag-devs · Jul 28, 2024 · e44bfd1 · e44bfd1
1 parent a708b24
commit e44bfd1
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 26 deletions.
diff --git a/include/generator.i.hpp b/include/generator.i.hpp
@@ -171,8 +171,12 @@ inline auto get_args_usage(const State& state) {
 }
 
 inline auto set_binary_mode() {
-#ifdef ON_WINDOWS
-  _setmode(fileno(stdout), _O_BINARY);  // Sets file mode to binary
+  /*
+    We recommend using binary mode on Windows. However, Codeforces Polygon doesn’t think so.
+    Since the only Online Judge that uses Windows seems to be Codeforces, make it happy.
+  */
+#if defined(ON_WINDOWS) && !defined(ONLINE_JUDGE)
+  _setmode(fileno(stdout), _O_BINARY);
 #endif
 }
 }  // namespace detail

diff --git a/include/interactor.hpp b/include/interactor.hpp
@@ -174,17 +174,12 @@ struct State {
    */
   ~State();
 
-  /**
-   * Disables the check for redundant content of `from_user` stream.
-   */
-  auto disable_check_dirt() -> void;
-
   /**
    * Quits the interactor with the given report.
    *
    * @param report The report to be reported.
    */
-  [[noreturn]] auto quit(Report report) -> void;
+  [[noreturn]] auto quit(const Report& report) -> void;
 
   /**
    * Quits the interactor with the `report::Status::ACCEPTED` status.
@@ -210,9 +205,6 @@ struct State {
  private:
   /// Whether the program has exited.
   bool exited_{false};
-
-  /// Whether to check for redundant content in the `from_user` stream.
-  bool check_dirt_{true};
 };
 
 /**

diff --git a/include/interactor.i.hpp b/include/interactor.i.hpp
@@ -29,7 +29,6 @@
 
 /* cplib_embed_ignore start */
 #include "cmd_args.hpp"
-#include "io.hpp"
 #include "json.hpp"
 #include "macros.hpp"
 #include "utils.hpp"
@@ -135,18 +134,9 @@ inline State::~State() {
   if (!exited_) panic("Interactor must exit by calling method `State::quit*`");
 }
 
-inline auto State::disable_check_dirt() -> void { check_dirt_ = true; }
-
-inline auto State::quit(Report report) -> void {
+inline auto State::quit(const Report& report) -> void {
   exited_ = true;
 
-  if (check_dirt_ &&
-      (report.status == Report::Status::ACCEPTED ||
-       report.status == Report::Status::PARTIALLY_CORRECT) &&
-      !from_user.inner().seek_eof()) {
-    report = Report(Report::Status::WRONG_ANSWER, 0.0, "Extra content in the user output");
-  }
-
   reporter->report(report);
 
   std::clog << "Unrecoverable error: Reporter didn't exit the program\n";

diff --git a/include/io.i.hpp b/include/io.i.hpp
@@ -43,8 +43,12 @@ namespace detail {
 struct FdOutBuf : std::streambuf {
  public:
   explicit FdOutBuf(int fd) : fd_(fd) {
-#ifdef ON_WINDOWS
-    _setmode(fd_, _O_BINARY);  // Sets file mode to binary
+    /*
+      We recommend using binary mode on Windows. However, Codeforces Polygon doesn’t think so.
+      Since the only Online Judge that uses Windows seems to be Codeforces, make it happy.
+    */
+#if defined(ON_WINDOWS) && !defined(ONLINE_JUDGE)
+    _setmode(fd_, _O_BINARY);
 #endif
   }
 
@@ -80,8 +84,12 @@ struct FdInBuf : std::streambuf {
    * => Force underflow()
    */
   explicit FdInBuf(int fd) : fd_(fd) {
-#ifdef ON_WINDOWS
-    _setmode(fd_, _O_BINARY);  // Sets file mode to binary
+    /*
+      We recommend using binary mode on Windows. However, Codeforces Polygon doesn’t think so.
+      Since the only Online Judge that uses Windows seems to be Codeforces, make it happy.
+    */
+#if defined(ON_WINDOWS) && !defined(ONLINE_JUDGE)
+    _setmode(fd_, _O_BINARY);
 #endif
     setg(buf_.data() + PB_SIZE,   // Beginning of putback area
          buf_.data() + PB_SIZE,   // Read position