Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workaround to fix client hanging caused by startup deploying in Server #1281

Merged
merged 1 commit into from
Jun 5, 2024
Merged

workaround to fix client hanging caused by startup deploying in Server #1281

merged 1 commit into from
Jun 5, 2024

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Jun 3, 2024

fix #1279

@fxliang fxliang requested a review from lotem June 3, 2024 09:29
lotem
lotem approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要是没部署岂不是用不了。

第二个用户大概会是这种情况。
如果确定是这里会出问题那就改吧。

@fxliang
Copy link
Contributor Author

fxliang commented Jun 3, 2024

要是没部署岂不是用不了。

第二个用户大概会是这种情况。 如果确定是这里会出问题那就改吧。

不知道是进程从属还是什么原因，issue里描述的情况确实会卡死，如果用deployer 来部署就没问题🙃

@fxliang fxliang merged commit 95a4192 into rime:master Jun 5, 2024
1 check passed
@fxliang fxliang deleted the fix1279 branch June 5, 2024 11:32
@LEOYoon-Tsaw LEOYoon-Tsaw changed the title walkaround to fix client hanging caused by startup deploying in Server workaround to fix client hanging caused by startup deploying in Server Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fxliang @lotem