Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add resource info for windows MSVC build #845

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

fxliang
Copy link
Contributor

@fxliang fxliang commented Mar 11, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request
image
image

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@fxliang fxliang changed the title chore: add resource info for windows build chore: add resource info for windows MSVC build Mar 11, 2024
src/CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
src/rime.rc Outdated Show resolved Hide resolved
src/rime.rc Outdated Show resolved Hide resolved
src/rime.rc Outdated Show resolved Hide resolved
src/rime.rc Outdated Show resolved Hide resolved
src/rime.rc Outdated Show resolved Hide resolved
src/CMakeLists.txt Outdated Show resolved Hide resolved
@lotem
Copy link
Member

lotem commented Mar 11, 2024

It's definitely not chore.

maybe start the commit message with build:

@fxliang fxliang changed the title chore: add resource info for windows MSVC build build: add resource info for windows MSVC build Mar 11, 2024
@lotem lotem merged commit 1496dc1 into rime:master Mar 11, 2024
10 checks passed
@fxliang fxliang deleted the resinfo branch March 12, 2024 04:11
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants