Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(switcher): superfluously load saved options #842

Merged
merged 3 commits into from
Mar 10, 2024
Merged

Conversation

lotem
Copy link
Member

@lotem lotem commented Mar 9, 2024

Pull request

Issue tracker

the issue is mentioned here #818 (comment)

Feature

let Switcher object live across schema switching.
restore saved options only after input session is created.
save options on schema switching as before, but called explicitly.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@lotem lotem requested a review from eagleoflqj March 9, 2024 15:55
@lotem
Copy link
Member Author

lotem commented Mar 10, 2024

LGTM

@lotem lotem merged commit e0dde5d into rime:master Mar 10, 2024
10 checks passed
@lotem lotem deleted the switcher branch March 11, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant