Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(glog): no read permission on the cwd on Android #835

Merged
merged 6 commits into from
Mar 4, 2024
Merged

fix(glog): no read permission on the cwd on Android #835

merged 6 commits into from
Mar 4, 2024

Conversation

mokapsing
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@mokapsing mokapsing marked this pull request as ready for review March 4, 2024 08:29
ksqsf
ksqsf reviewed Mar 4, 2024
View reviewed changes
src/rime/lever/deployment_tasks.cc Outdated Show resolved Hide resolved
src/rime/lever/deployment_tasks.cc Show resolved Hide resolved
ksqsf
ksqsf approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@ksqsf ksqsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@ksqsf ksqsf merged commit edee320 into rime:master Mar 4, 2024
9 checks passed
@mokapsing mokapsing deleted the fix_android_permission branch March 4, 2024 15:09
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@mokapsing @graphemecluster
fix(glog): no read permission on the cwd on Android (rime#835)
bb10957
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@mokapsing @graphemecluster
fix(glog): no read permission on the cwd on Android (rime#835)
2952f0c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksqsf ksqsf ksqsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mokapsing @ksqsf