Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade github action to v4 #814

Merged
merged 1 commit into from
Feb 12, 2024
Merged

ci: upgrade github action to v4 #814

merged 1 commit into from
Feb 12, 2024

Conversation

Bambooin
Copy link
Contributor

@Bambooin Bambooin commented Feb 11, 2024

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

The @actions/artifact was kept v3 due to breaking change.
https://github.com/actions/upload-artifact

Due to how Artifacts are created in this new version, it is no longer possible to upload to the same named Artifact multiple times. You must either split the uploads into multiple Artifacts with different names, or only upload once. Otherwise you will encounter an error.

This will dismiss the warning of deprecated Node.js 16

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@Bambooin Bambooin marked this pull request as draft February 11, 2024 15:13
@Bambooin Bambooin force-pushed the master branch 2 times, most recently from aa2441a to e0b7028 Compare February 12, 2024 01:27
@Bambooin Bambooin marked this pull request as ready for review February 12, 2024 02:12
.github/workflows/macos-build.yml Outdated Show resolved Hide resolved
This will dismiss the warning of deprecated Node.js 16

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, actions/upload-artifact@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@eagleoflqj eagleoflqj merged commit 878dd5c into rime:master Feb 12, 2024
9 checks passed
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants