feat(config): best effort resolution for circurlar dependencies #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lotem
reviewed
Sep 21, 2017
| static bool HasCircularDependencies(ConfigDependencyGraph* graph, | ||
| const string& path) { | ||
| for (const auto& x : graph->resolve_chain) { | ||
| if (boost::starts_with(x, path) && |
There was a problem hiding this comment.
path 的字符串比較，對 map 有效，list index 則除了數值還有關鍵字寫法，如 @last。所以這個檢查不夠完全。
lotem
reviewed
Sep 21, 2017
| @@ -0,0 +1,8 @@ | |||
| test: | |||
| __include: sometimes? | |||
| home: excited | |||
There was a problem hiding this comment.
我覺得例子這樣寫可以更好地描述行爲：
通過 patch 修改 test/home 的值，然後測試 test/work 引用了 patch 之前的值。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix the reported issue in #150 (comment)