use literals in distributed engine definition in ch #6446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-anshul
requested changes
Jan 17, 2025
k-anshul
reviewed
Jan 18, 2025
| @@ -609,7 +609,7 @@ func (c *connection) createTable(ctx context.Context, name, sql string, outputPr | |||
| database = "currentDatabase()" | |||
| } | |||
| fmt.Fprintf(&distributed, "CREATE OR REPLACE TABLE %s %s AS %s", safeSQLName(name), onClusterClause, safelocalTableName(name)) | |||
| fmt.Fprintf(&distributed, " ENGINE = Distributed(%s, %s, %s", safeSQLName(c.config.Cluster), database, safelocalTableName(name)) | |||
| fmt.Fprintf(&distributed, " ENGINE = Distributed(%s, %s, %s", safeSQLString(c.config.Cluster), database, safeSQLString(localTableName(name))) | |||
There was a problem hiding this comment.
I know this is an existing code but shouldn't database also be quoted ?
If you do quote this then need to take care of fact that database can also be currentDatabase().
There was a problem hiding this comment.
Yes I did not quote because of existing code but added it now
k-anshul
approved these changes
Jan 18, 2025
pjain1
added a commit
that referenced
this pull request
Jan 18, 2025
* use literals in distributed engine definition in ch * do not quote db * use safe sql string * quote database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise it was quoting the local table name like
ENGINE = Distributed('abc', 'default', '"table_local"', rand())and queries were failing on it saying local table not found