feat: dimension and measure filter for canvas #6396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericpgreen2
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
@briangregoryholmes is your proposal that we lift the StateManagers even further up the component tree, or keep them here?
ericpgreen2
reviewed
Jan 21, 2025
Comment on lines
+246
to
+252
| void queryClient.refetchQueries( | ||
| getQueryServiceResolveCanvasQueryKey( | ||
| this.instanceId, | ||
| res.name.name, | ||
| {}, | ||
| ), | ||
| ); |
There was a problem hiding this comment.
Ideally we use invalidateQueries, though it might not work due to this: https://github.com/rilldata/rill-private-issues/issues/719
| } from "@rilldata/web-common/runtime-client"; | ||
| import { derived, type Readable } from "svelte/store"; | ||
| import { derived, get, type Readable } from "svelte/store"; | ||
|
|
||
| export class CanvasResolvedSpec { | ||
| canvasSpec: Readable<V1CanvasSpec | undefined>; | ||
| isLoading: Readable<boolean>; |
There was a problem hiding this comment.
Do we need isError and error for error handling?
There was a problem hiding this comment.
If so, might it be easier to expose the $validSpecStore itself, rather than duplicating the fields that map 1:1 to the TanStack Query response? If so, maybe the exposure of the useCanvas response belongs in the top-level CanvasEntity class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds dimension and measure filters for canvas.
Merge after #6411
TODOs