fix: billing email and deploy paywall copy #6132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
AdityaHegde
commented
Nov 22, 2024
•
AdityaHegde
commented
- Update various email related copy https://www.notion.so/rilldata/Email-adjustments-146ba33c8f57808e9eddc1a3828d6bdc
- Update the paywall during deploy to be aware of trial plan.
- Update the percent calculation on trial orgs usage.
ericpgreen2
approved these changes
Nov 25, 2024
| @@ -15,7 +15,7 @@ | |||
| <mj-body> | |||
| <mj-section padding-top="24px"> | |||
| <mj-column> | |||
| <mj-image container-background-color="#FFF" width="48px" src="https://cdn.rilldata.com/email-transactional/rill-logo.png" /> | |||
| <mj-image container-background-color="#FFF" width="48px" src="https://cdn.rilldata.com/email-transactional/rill-logo-purple-square" /> | |||
There was a problem hiding this comment.
It'd be nice if this asset had a file extension
| export function extractDeployError(error: ConnectError): DeployError { | ||
| export function extractDeployError( | ||
| error: ConnectError, | ||
| orgOnTrial: boolean, |
There was a problem hiding this comment.
This feels like a random parameter to add to this function – because it doesn't relate to "extracting" information from the error message. Maybe it'd make sense with a small name change: makeDeployError, makePrettyDeployError?
AdityaHegde
added a commit
that referenced
this pull request
Nov 26, 2024
* Update some billing email copy * Update quota error to match plan * Fix trial org usage percent * PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.